DatingDapp
First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

[I-1] Internal Functions Should Follow Naming Conventions (Use Leading Underscore)

agmguindo

Description:

In Solidity, internal functions should follow the convention of using a leading underscore (_) in their names. This helps distinguish them from external or public functions, improving readability and maintainability. In LikeRegistry.sol, the function matchRewards is declared as internal, but it does not follow this naming convention.

function matchRewards(address from, address to) internal {}
​

Recommended Mitigation:

To align with best practices and improve code clarity, add an underscore (_) at the beginning of the function name.

​
- function matchRewards(address from, address to) internal {}
+ function _matchRewards(address from, address to) internal {}
​
Updates

Appeal created

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.