Submission Details
Severity:
Incorrect modifider logic
Summary
The "MultiSigWallet::onlyOwners" modifier incorrectly uses && instead of "OR , ||" and as such the functions that use it are not usable. It checks [msg.sender be equal to owner1] and [msg.sender be equal to owner2] at same time instead of "OR".
modifier onlyOwners() {
if (msg.sender != owner1 && msg.sender != owner2) revert NotAnOwner();
_;
}
Vulnerability Details
Impact
Below methods aren't usable since they're tagged with the above modifier(MultiSigWallet contract).
function executeTransaction(), function submitTransaction() and function approveTransaction()
Tools Used
Manual review
Recommendations
Use "OR, || " instead of "AND, &&"
Rewards breakdown
nSLOC
197This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.