Submission Details
Severity:
There is no method to view the generated wallet address; an event should at least be emitted.
Description: The matchRewards function generates a wallet address for the matched users, but there is no way to check the generated wallet address.
Impact: the user is hard to access the wallet.
Recommended Mitigation:
add a emit event with the address
+ event MatchRewards(address indexed user1, address indexed user2, address wallet);
...
function matchRewards(address from, address to) internal {
uint256 matchUserOne = userBalances[from][to];
uint256 matchUserTwo = userBalances[to][from];
userBalances[from][to] = 0;
userBalances[to][from] = 0;
uint256 totalRewards = matchUserOne + matchUserTwo;
uint256 matchingFees = (totalRewards * FIXEDFEE) / 100;
uint256 rewards = totalRewards - matchingFees;
totalFees += matchingFees;
// Deploy a MultiSig contract for the matched users
MultiSigWallet multiSigWallet = new MultiSigWallet(from, to);
+ emit MatchRewards(from, to, address(multiSigWallet));
Updates
Appeal created
n0kto 5 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational or Gas
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Rewards breakdown
nSLOC
197This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.