DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

When users send ETH directly to the `LikeRegistry` contract there is no way to withdraw funds resulting in ETH being locked in contract

Summary

If users send ETH directly to the LikeRegistrycontract without calling a function funds will be lost because there is no way to withdraw the ETH.

Impact

Loss of funds because the withdrawFeesfunction on withdraws totalFees.

Tools Used

Manual code review

Recommendations

Update the totalFeesvariable in the receivefunction so its possible for the owner to withdraw the funds:

receive() external payable {
+ totalFees += msg.value
}
Updates

Appeal created

n0kto Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

invalid_receive_function

Not the best design, but if you send money accidentally, that's a user mistake. Informational.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.