DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

no way to revoke Approval

Summary

The contract MultiSig.sol lacks functionality for owners to revoke approvals on pending transactions. Once an owner approves a transaction, the approval is permanent, even if the owner changes their mind or identifies a mistake.

P O C

  1. Owner1 approves Transaction A.

  2. Owner1 realizes Transaction A is malicious but cannot revoke approval.

  3. Owner2 approves Transaction A, allowing execution.

Vulnerability Details

Impact

Malicious or accidental approvals cannot be undone, forcing owners to either execute unwanted transactions or leave them pending indefinitely

Tools Used

Manual Review

Recommendations

Add a revokeApproval function

Updates

Appeal created

n0kto Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Design choice
Assigned finding tags:

Users mistake, only impacting themselves.

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.