DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: high
Invalid

User Balances Not Being Tracked

The contract declares a mapping to track user balances but fails to update it when users deposit or send Ether. This oversight results in inaccurate balance tracking, which can cause financial discrepancies.

``` mapping(address => uint256) public userBalances;

``` However, the contract does not update this mapping when users send funds. As a result, deposits remain untracked, preventing the contract from verifying whether a user has made a payment.

Recommendations

  • Ensure that the userBalances mapping is updated whenever a user deposits Ether.

Updates

Appeal created

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
Assigned finding tags:

finding_likeUser_no_userBalances_updated

Likelihood: High, always. Impact: High, loss of funds

0xzulkefal Submitter
10 months ago
n0kto Lead Judge
10 months ago
0xzulkefal Submitter
10 months ago
n0kto Lead Judge
10 months ago
0xzulkefal Submitter
10 months ago
n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality
Assigned finding tags:

finding_likeUser_no_userBalances_updated

Likelihood: High, always. Impact: High, loss of funds

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!