DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: medium
Valid

The funds obtained from a burned or blocked profile is kept in the contract.

Summary

When a user profile is burned, the funds sent to the contract from likes are kept in the contract and not sent back to the user.

Vulnerability Details

When a user is burned using the SoulboundProfileNFT::burnProfile or the SoulboundProfileNFT::blockProfile, the funds sent to the contract from likes are kept in the contract and not sent back to the user.

Impact

Users who delete their accounts are not returned their funds.

Tools Used

N/A

Recommendations

  1. Decide whether the owner of the contract should keep the money obtained from burned users, or the money should be sent back to the user.

  2. If the money is to be sent back to the user, add a transfer in the SoulboundProfileNFT::burnProfile and the SoulboundProfileNFT::blockProfile functions to send the money back to the user.

Updates

Appeal created

n0kto Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding_blocking_or_burning_no_refund_balances_or_multisig

Likelihood: Low, burning with money in it would be a user mistake, and being blocked is Low. Impact: High, loss of funds

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.