DatingDapp
First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Previous Next
Submission Details
Severity: low
Invalid

Overpayment Allowed

parmakhanm786

Summary

where users are required to send at least 1 ETH, but the function does not enforce an exact 1 ETH payment, allowing users to send excess ETH without a refund.

Description

The function currently allows users to send more than 1 ETH, which contradicts the protocol's requirement.
No mechanism exists to reject or refund excess ETH, meaning some users could unintentionally overpay.
The issue is not critical but leads to inefficiencies and user experience concerns.

Impact

Users might accidentally send more ETH without receiving a refund.
Some users may pay more while others pay exactly 1 ETH, leading to inconsistencies.

Recommendation

function likeUser(
address liked
) external payable {
​
- require(msg.value >= 1 ether, "Must send at least 1 ETH");
+ require(msg.value == 1 ether);
require(!likes[msg.sender][liked], "Already liked");
require(msg.sender != liked, "Cannot like yourself");
require(profileNFT.profileToToken(msg.sender) != 0, "Must have a profile NFT");
require(profileNFT.profileToToken(liked) != 0, "Liked user must have a profile NFT");
​
likes[msg.sender][liked] = true;
emit Liked(msg.sender, liked);
​
// Check if mutual like
if (likes[liked][msg.sender]) {
matches[msg.sender].push(liked);
matches[liked].push(msg.sender);
emit Matched(msg.sender, liked);
matchRewards(liked, msg.sender);
}
}
​
Updates

Appeal created

n0kto Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Users mistake, only impacting themselves.

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.