DatingDapp

First Flight #33
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

Integer Overflow in Fee Calculation

Summary

Integer Overflow in Fee Calculation

Vulnerability Details

uint256 matchingFees = (totalRewards * FIXEDFEE) / 100;
If totalRewards is very large, it can overflow and cause unexpected behavior.

Impact
Integer Overflow

Tools Used
Mannualy

Recommendations

import "@openzeppelin/contracts/utils/math/SafeMath.sol";

using SafeMath for uint256;
uint256 matchingFees = totalRewards.mul(FIXEDFEE).div(100);

Updates

Appeal created

n0kto Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.