The NotEnoughApprovals
error in MultiSig.sol
is defined in the contract but is never used. Instead, the contract relies on a string-based revert message in require
statements.
The contract defines the custom error `NotEnoughApprovals, but is not used anywhere in the code. Instead, the following line uses a string-based error message:
Using string-based error messages instead of custom errors increases gas costs because strings consume more storage and processing compared to custom errors.
Increased gas costs when reverting transactions due to inefficient error handling.
The presence of an unused error may indicate incomplete implementation or code redundancy.
Manual Review
Replace the string-based revert message with the NotEnoughApprovals custom error to optimize gas usage and improve contract readability
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.