Submission Details
Severity:
External Calls Without Error Handling
Summary
The calls to gmxReader.getMarket() and IOracle(oracle).getPrimaryPrice() are external calls
Vulnerability Details
function getMarketPrices(address market) internal view returns (MarketPrices memory) {MarketPrices memory prices;MarketProps memory marketInfo = gmxReader.getMarket(address(dataStore),market);address oracle = IOrderHandler(orderHandler).oracle();prices.indexTokenPrice = IOracle(oracle).getPrimaryPrice(marketInfo.indexToken);prices.longTokenPrice = IOracle(oracle).getPrimaryPrice(marketInfo.longToken);prices.shortTokenPrice = IOracle(oracle).getPrimaryPrice(marketInfo.shortToken);return prices;}
Impact
Tools Used
Recommendations
Add try-catch blocks or require checks to ensure these calls succeed:
require(address(gmxReader) != address(0), "Invalid GMX Reader address");
require(oracle != address(0), "Invalid Oracle address");
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
1,91026 USDC / LOC
47,500
2,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.