Liquidity Management
Gamma
DeFiFoundry
50,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Code inconsistency of the planned documentation on the floating range of governanceFee

druzh

Summary

A hard-coded value, although, according to the documentation, it should be possible to select a value from a specified range.

Vulnerability Details

governanceFee (protocol fee) is specified in the documentation from 1% to 20% (100-2000), and 500 (5%) is initialized by default. There is no direct restriction in the code, but in the documentation it is expected that the contract owner adheres to the declared.

Impact

Transparency of the protocol for the end user. There is a significant need to upgrade the contract every time in order to update the governanceFee.

Tools Used

Foundry unit tests.

Recommendations

For an additional guarantee, you can add this function:

function setGovernanceFee(uint256 newFee) external onlyOwner {
require(newFee >= 100 && newFee <= 2000, "governanceFee out of bounds");
governanceFee = newFee;
}
Updates

Lead Judging Commences

n0kto Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.