Redundant State Variable Causing Storage Inefficiency
Summary
The KeeperProxy contract contains a threshold state variable that is not used when implementing its functionality via the priceDiffThreshold mapping. This creates unnecessary storage overhead.
Vulnerability Details
The contract declares a state variable that is never used while implementing the same functionality through a mapping:
The threshold variable is declared but never used in any function that would occupy a storage slot unnecessarily and has no initialization in the constructor or initialize function.
Impact
Unnecessary storage slot allocation
Tools Used
Manual review
Recommendations
Remove the unused state variable
Lead Judging Commences
Informational or Gas
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Informational or Gas
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.