DeFiFoundry
50,000 USDC
View results
Submission Details
Severity: medium
Invalid

`cancelFlow()` can be frontrun and a wrong depositId will be used

Summary

If the keeper wants to cancel the current flow, he will use the current counter, but if the user had just created one before that, it will try to cancel the just created flow, not the one we intended.

We should be able to put a param in cancelFlow(), which will be counter, so it can correctly delete the intended depositInfo

Impact

Deleting an unintended deposit - broken functionality.

Tools Used

Manual review

Recommendations

Have a param that is configurable by the user.

Updates

Lead Judging Commences

n0kto Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.