DeFiFoundry
50,000 USDC
View results
Submission Details
Severity: low
Invalid

Slippage protection in the deposit function

Title

Slippage protection in the deposit function

Summary

The current deposit system in the protocol doesn't protect users from potential value losses during transactions. This makes it risky for users because they could end up with fewer assets than expected.

Vulnerability Details

The deposit function does not allow users to specify the minimum share amount they want to receive.
Because the deposit is not completed in one transaction, the user can get less share amount according to the market condition at the time of deposit.

Impact

Without this protection, users could lose value when they deposit funds.

Tools Used

Manual Review

Recommendations

A slippage protection mechanism should be added. This would let users set a minimum amount of shares they're willing to accept, preventing unexpected losses during deposits.

Updates

Lead Judging Commences

n0kto Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

invalid_shares_slippage

Shares represent a part of the vault. Even if someone performs a frontrun or sandwich attack, you will still have the corresponding amount of shares representing your deposit. A user could add liquidity two days later, and you would still have the same amount of shares.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.