function deposit in PerpetualVault.sol does not follow CEI (checks effects interactions).
Summary
The deposit function in PerpetualVault.sol does not follow the Checks-Effects-Interactions (CEI) pattern, making it vulnerable to reentrancy attacks if the nonReentrant modifier hadn't been used.
Vulnerability Details
The function updates the contract state after an external call
Impact
Without the nonReentrant Modifier it would cause a reentrancy.
Tools Used
Recommendations
Follow CEI
Lead Judging Commences
Suppositions
There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.