Liquidity Management

Summary

here in the settle, we are not verifying whether the queue is Settle. we shouldn't call the settle with an already settled queue.

Vulnerability Details

function settle(
IGmxProxy.OrderData memory orderData
) external returns (bytes32) {
require(msg.sender == perpVault, "invalid caller");

require(msg.sender == perpVault, "invalid caller");

uint256 positionExecutionFee = getExecutionGasLimit(
Order.OrderType.MarketDecrease,
orderData.callbackGasLimit
) * tx.gasprice;

require(
address(this).balance >= positionExecutionFee,
"insufficient eth balance"
);

.........

bytes32 requestKey = gExchangeRouter.createOrder(params);

queue.requestKey = requestKey;

@>>queue.isSettle = true;

return requestKey;

Impact

wrong verification of settle.

Tools Used

Recommendations

verify that queue.isSettle! = true starting of settle function.