Missing _disableInitializers() in the constructor in PerpetualVault
Summary:
The PerpetualVault contract is an upgradeable Smart Contract and is missing the _disableInitializers() function call in its constructor. As a result, an attacker could re-initialize the contract, passing in any arguments they want.
Impact:
An attacker could take over ownership of the contract
Tools Used:
Manual review
Recommendations:
You should invoke the _disableInitializers() function from Openzeppelin in the constructor to automatically lock it when it is deployed:
Lead Judging Commences
Informational or Gas
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.