DeFiFoundry
50,000 USDC
View results
Submission Details
Severity: low
Invalid

Oracle Manipulation Risk (Price Manipulation)

Summary

The function willPositionCollateralBeSufficient relies on prices.shortTokenPrice.min.toInt256() for collateral calculations. If an attacker can manipulate the oracle or TWAP pricing, they may artificially inflate collateral value, bypassing margin requirements.

Vulnerability Details

function willPositionCollateralBeSufficient(
IDataStore dataStore,
MarketProps memory market,
MarketPrices memory prices,
bool isLong,
WillPositionCollateralBeSufficientValues memory values
) external view returns (bool, int256) {
PriceProps memory collateralTokenPrice = prices.shortTokenPrice;
@>>int256 remainingCollateralUsd = values.positionCollateralAmount.toInt256() * collateralTokenPrice.min.toInt256();

Impact

A trader could open positions with artificially low collateral requirements.

Attackers might manipulate prices to avoid liquidation or force wrongful liquidations.

Tools Used

Recommendations

Updates

Lead Judging Commences

n0kto Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Suppositions

There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.

n0kto Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Suppositions

There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.