Submission Details
Severity:
The `isSequencerUp` flag is used incorrectly
Summary
The isSequencerUp flag is used incorrectly.
Vulnerability Details
contracts/KeeperProxy.sol#L164
The _validatePrice function uses the isSequencerUp flag incorrectly, which prevents the protocol from functioning properly. When answer == 0, isSequencerUp should be False and should not pass the require check.
function _validatePrice(address perpVault, MarketPrices memory prices) internal view {
// L2 Sequencer check
(
/*uint80 roundID*/,
int256 answer,
uint256 startedAt,
/*uint256 updatedAt*/,
/*uint80 answeredInRound*/
) = AggregatorV2V3Interface(sequencerUptimeFeed).latestRoundData();
bool isSequencerUp = answer == 0;
require(isSequencerUp, "sequencer is down");
...
}
Impact
This problem will prevent the protocol from functioning properly.
Tools Used
Recommendations
It is recommended to change bool isSequencerUp = answer == 0; to bool isSequencerUp = answer != 0; to fix this issue.
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
1,91026
USDC / LOC
47,500
2,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.