Liquidity Management
Gamma
DeFiFoundry
50,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

their are check missing for some functions

sagsick

Summary

in KeeperProxy.soltheir are some functions like setDataFeed,setThreshold, setMaxTimewindow.this function taking values but they are checking properly

Vulnerability Details

this funcion should check the `_maxTimeWindow`and the `_threshold` parameter.

function setDataFeed(address token, address feed, uint256 _maxTimeWindow, uint256 _threshold) external onlyOwner {
require(token != address(0), "zero address");
require(feed != address(0), "zero address");
dataFeed[token] = feed;
//here should check the value are not 0 _maxTimeWindow and _threshold
maxTimeWindow[token] = _maxTimeWindow;
priceDiffThreshold[token] = _threshold;
}

Another function setThresholdshould check the value are are not 0.

function setThreshold(address token, uint256 _threshold) external onlyOwner {
require(_threshold > 0, "zero value");
//here token value should check that it is not address(0)
priceDiffThreshold[token] = _threshold;
}

Another function`setMaxTimeWindow` this function should chekc the token is not a adress(0)

function setMaxTimeWindow(address token, uint256 _maxTimeWindow) external onlyOwner {
require(_maxTimeWindow > 0, "zero value");
//here the token value should not be address(0)
maxTimeWindow[token] = _maxTimeWindow;
}

Impact

if the values are not check properly the value which are set accidently can cause the contract operate diffrently.

Tools Used

manually

Recommendations

add the check to all the functions which are describe above

Updates

Lead Judging Commences

n0kto Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Admin is trusted / Malicious keepers

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point. Keepers are added by the admin, there is no "malicious keeper" and if there is a problem in those keepers, that's out of scope. ReadMe and known issues states: " * System relies heavily on keeper for executing trades * Single keeper point of failure if not properly distributed * Malicious keeper could potentially front-run or delay transactions * Assume that Keeper will always have enough gas to execute transactions. There is a pay execution fee function, but the assumption should be that there's more than enough gas to cover transaction failures, retries, etc * There are two spot swap functionalies: (1) using GMX swap and (2) using Paraswap. We can assume that any swap failure will be retried until success. " " * Heavy dependency on GMX protocol functioning correctly * Owner can update GMX-related addresses * Changes in GMX protocol could impact system operations * We can assume that the GMX keeper won't misbehave, delay, or go offline. " "Issues related to GMX Keepers being DOS'd or losing functionality would be considered invalid."

n0kto Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Admin is trusted / Malicious keepers

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point. Keepers are added by the admin, there is no "malicious keeper" and if there is a problem in those keepers, that's out of scope. ReadMe and known issues states: " * System relies heavily on keeper for executing trades * Single keeper point of failure if not properly distributed * Malicious keeper could potentially front-run or delay transactions * Assume that Keeper will always have enough gas to execute transactions. There is a pay execution fee function, but the assumption should be that there's more than enough gas to cover transaction failures, retries, etc * There are two spot swap functionalies: (1) using GMX swap and (2) using Paraswap. We can assume that any swap failure will be retried until success. " " * Heavy dependency on GMX protocol functioning correctly * Owner can update GMX-related addresses * Changes in GMX protocol could impact system operations * We can assume that the GMX keeper won't misbehave, delay, or go offline. " "Issues related to GMX Keepers being DOS'd or losing functionality would be considered invalid."

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.