DeFiFoundry
50,000 USDC
View results
Submission Details
Severity: low
Invalid

balanceBeforeWithdrawal does not accurately reflect the essence of the calculation

Summary

the logic of the code may be quite reasonable in the context of the internal workings of the withdraw function. However, the name of the variable does not accurately reflect the essence of the calculation

uint256 balanceBeforeWithdrawal = collateralToken.balanceOf(address(this)) - withdrawn;

Recommendations

correct the variable name

Updates

Lead Judging Commences

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.