Submission Details
Severity:
PnL not rounded in protocol's favour during withdrawal
Description
pnl calculation needs to be in favour of the protocol. The correct code ought to be:
- collateralDeltaAmount = collateralDeltaAmount - feeAmount - uint256(-pnl) / prices.shortTokenPrice.max;
+ collateralDeltaAmount = collateralDeltaAmount - feeAmount - uint256(-pnl) / prices.shortTokenPrice.min;
Division should occur by shortToken's min price, not the max price.
Impact
User is able to withdraw more and protocol receives lesser negative PnL position fee.
Updates
Lead Judging Commences
n0kto 9 months ago
Submission Judgement Published Assigned finding tags:
finding_withdraw_use_prices.shortTokenPrice.max_instead_of_min
Likelihood: Low/Medium, every withdraw, position opened, not liquidated, beenShort or not 1, and the difference between minPrice and maxPrice is significant. Impact: Low, small part of feeAmount and PnL not deducted from collateralDeltaAmount.
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
1,91026
USDC / LOC
47,500
2,500
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.