Missing Reentrancy Guard in GmxProxy::createOrder function
Summary
The createOrder function in GmxProxy is missing a nonReentrant modifier. This function is critical as it facilitates order creation while handling token approvals, transfers, and ETH balance verification. Given that it interacts with multiple external contracts, including gExchangeRouter, the absence of a reentrancy guard could allow malicious actors to exploit potential reentrancy vulnerabilities.
Vulnerability Details
createOrder function is GmxProxy does external call and also is a very critical function, Therefor it is wise to include the nonReentrant modifier.
Impact
The function approves and transfers tokens, making it susceptible to token balance inconsistencies or drain attacks if reentrancy is exploited.
Tools Used
Manual Review
Recommendations
Use the nonReentrant Modifier
Lead Judging Commences
Suppositions
There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.
Suppositions
There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.