Locked ETH in GmxProxy due to failed transfers.
Summary
The GmxProxy.createOrder function approves arbitrary amounts to gmxRouter, risking residual allowances.
Vulnerability Details
When creating orders, safeApprove is used with orderData.amountIn.
If the order fails or is canceled, the approval remains, allowing potential misuse.
Impact
Residual approvals could allow unauthorized transfers if gmxRouter is compromised.
Tools Used
Manual Review
Recommendations
Use safeIncreaseAllowance or reset approvals to zero after each transaction.
Lead Judging Commences
Informational or Gas
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.