DeFiFoundry
50,000 USDC
View results
Submission Details
Severity: low
Invalid

Potential for Incorrect Calculations in getExecutionGasLimit Function could lead to failed transactions

Summary

The getExecutionGasLimit function does not fully validate the gas limit data, such as checking for negative values or ensuring the data is within expected ranges.

Vulnerability Details

https://github.com/CodeHawks-Contests/2025-02-gamma/blob/84b9da452fc84762378481fa39b4087b10bab5e0/contracts/interfaces/IGmxProxy.sol#L45

Proof of Concept (PoC):

  • GMX returns incorrect gas limit data due to a bug or manipulation.

  • The getExecutionGasLimit function uses the incorrect data to calculate the execution gas limit, leading to incorrect gas estimations.

  • Example:

    function getExecutionGasLimit(Order.OrderType orderType, uint256 callbackGasLimit) external view returns (uint256 executionGasLimit) {
    // GMX-specific logic
    }

    If the gas limit data is incorrect, the execution gas limit calculation will be wrong.

Impact

Incorrect calculations could lead to failed transactions and protocol instability.

Tools Used

Recommendations

  • Add checks for negative values and ensure the gas limit data is within expected ranges.

  • Implement additional validation mechanisms to ensure data accuracy.

Updates

Lead Judging Commences

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Admin is trusted / Malicious keepers

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelihood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point. Keepers are added by the admin, there is no "malicious keeper" and if there is a problem in those keepers, that's out of scope. ReadMe and known issues states: " * System relies heavily on keeper for executing trades * Single keeper point of failure if not properly distributed * Malicious keeper could potentially front-run or delay transactions * Assume that Keeper will always have enough gas to execute transactions. There is a pay execution fee function, but the assumption should be that there's more than enough gas to cover transaction failures, retries, etc * There are two spot swap functionalies: (1) using GMX swap and (2) using Paraswap. We can assume that any swap failure will be retried until success. " " * Heavy dependency on GMX protocol functioning correctly * Owner can update GMX-related addresses * Changes in GMX protocol could impact system operations * We can assume that the GMX keeper won't misbehave, delay, or go offline. " "Issues related to GMX Keepers being DOS'd or losing functionality would be considered invalid."

Suppositions

There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!