DeFiFoundry
50,000 USDC
View results
Submission Details
Severity: low
Invalid

Hardcoded Gas Limit Calculation

Summary

The gas limit calculation for order execution is based on hardcoded values, limiting flexibility for different types of orders.

Vulnerability Details

The calculation of gas limits uses hardcoded values, such as oraclePriceCount = 5, which could result in inefficient or inaccurate gas estimations depending on the number of oracles or other dynamic factors.

Impact

Inaccurate gas limit calculations could lead to failed transactions or insufficient gas for order execution, especially for orders with varying complexity or multiple oracles.

Tools Used

Manual code review and analysis.

Recommendations

Make the gas limit calculation more dynamic by considering factors like the number of oracles or other variables specific to the order type.

Updates

Lead Judging Commences

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Design choice
Assigned finding tags:

Suppositions

There is no real proof, concrete root cause, specific impact, or enough details in those submissions. Examples include: "It could happen" without specifying when, "If this impossible case happens," "Unexpected behavior," etc. Make a Proof of Concept (PoC) using external functions and realistic parameters. Do not test only the internal function where you think you found something.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!