Submission Details
Severity:
Potential Failure of Non-Standard ERC20 Token Deposits on Treasury.sol
Summary
The deposit function uses IERC20.transferFrom which may fail on non-standard ERC20 tokens (e.g. tokens with no return value).
Vulnerability Details
IERC20(token).transferFrom(msg.sender, address(this), amount);
Impact
Deposits for certain tokens (e.g. USDT on Ethereum mainnet) will fail, reducing protocol compatibility.
Potential loss of funds if a revert is not handled.
Tools Used
Recommendations
Use OpenZeppelin's SafeERC20.safeTransferFrom to handle all types of ERC20 tokens.
SafeERC20.safeTransferFrom(IERC20(token), msg.sender, address(this), amount);
Updates
Lead Judging Commences
inallhonesty 4 months ago
Submission Judgement Published Reason: Known issue
Assigned finding tags:
[INVALID] SafeERC20 not used
LightChaser Low-60
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.