Core Contracts

Summary

The FeeCollector contract, which is responsible for managing and distributing protocol fees to veRAAC holders, creates time-weighted average periods but lacks the implementation to actually distribute these fees to holders. This contradicts the core functionality described in the documentation.

Vulnerability Details

According to the FeeCollector documentation:

In _processDistributions(), fees are tracked but not made claimable:

While the contract creates distribution periods, it lacks the crucial functionality to:

1. Make these fees claimable by veRAAC holders

2. Calculate and distribute rewards based on holders' voting power

3. Track and process actual fee distribution to individual holders

Impact

• veRAAC holders cannot claim their entitled share of protocol fees, leading to locked funds in the contract and failure to deliver promised rewards.

Tools Used

Manual Review

Recommendations

Implement the same logic to distribute the rewards as is done in BaseGauge. (As it uses TimeWeightedAveragefor creating period and rewards distribution)