Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Redundant Self-Assignment in DebtToken.sol

certikfire

Summary

A redundant self-assignment operation was identified in the burn function of the DebtToken contract. This unnecessary operation results in wasted gas consumption without providing any functional value.

Vulnerability Details

In the burn function, there is a redundant self-assignment:

amount = amount;

This operation:

  • Consumes gas unnecessarily

  • Provides no functional value

  • May indicate a missing intended operation

  • Located within the interest calculation block

Impact

  • Gas Inefficiency: Every execution of this function wastes gas on a no-op operation

  • Low Severity: No direct security implications

  • Code Quality: Reduces code readability and may cause confusion during maintenance

Tools Used

  • Manual code review

  • Static analysis

Recommendations

  1. Remove the redundant self-assignment:

//solidity:contracts/core/tokens/DebtToken.sol
if (userState[from].index != 0 && _userState[from].index < index) {
uint256 borrowIndex = ILendingPool(reservePool).getNormalizedDebt();
balanceIncrease = userBalance.rayMul(borrowIndex) - userBalance.rayMul(userState[from].index);
// Remove: amount = amount;
}

This change will:

  • Reduce gas consumption

  • Improve code clarity

  • Maintain identical functionality

  • Enhance code maintainability

Updates

Lead Judging Commences

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.