Submission Details
Severity:
updateReserveInterests will silently fail following deposit flow
In this flow LiquidityPool::deposit => ReserveLibrary::deposit => updateInterestRatesAndLiquidity => updateReserveInterests will silently fail. Because, at the beginning of ReserveLibrary::deposit, updateReserveInterests is called:
function deposit(
ReserveData storage reserve,
ReserveRateData storage rateData,
uint256 amount,
address depositor
) internal returns (uint256 amountMinted) {
if (amount < 1) revert InvalidAmount();
// Update reserve interests
updateReserveInterests(reserve, rateData);
Then, at the end of updateInterestRatesAndLiquidity updateReserveInterests is called once again.
// Update the reserve interests
updateReserveInterests(reserve, rateData);
But due to the following lines in updateReserveInterests
function updateReserveInterests(
ReserveData storage reserve,
ReserveRateData storage rateData
) internal {
uint256 timeDelta = block.timestamp -
uint256(reserve.lastUpdateTimestamp);
if (timeDelta < 1) {
return;
}
...
...
// Update the last update timestamp
reserve.lastUpdateTimestamp = uint40(block.timestamp);
Since timeDelta is still the same, this call will silently fail.
Recommendation
Remove the second call
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.