Submission Details
Severity:
rescueToken in RToken does not work
Summary
rescueToken in RToken cannot work because of the access control.
Vulnerability Details
In RToken, there is one function rescueToken(). This function aims to rescue tokens mistakenly sent to this contract.
There is one modifier onlyReservePool for this function. It means that only the lending pool can trigger this function.
The problem here is that the lending pool contract never trigger this function. This will cause this function does not work as expected.
function rescueToken(address tokenAddress, address recipient, uint256 amount) external onlyReservePool {
if (recipient == address(0)) revert InvalidAddress();
if (tokenAddress == _assetAddress) revert CannotRescueMainAsset();
IERC20(tokenAddress).safeTransfer(recipient, amount);
}
Impact
The feature rescueToken can not work as expected.
Tools Used
Manual
Recommendations
Add one interface in lending pool to trigger RToken::rescueToken().
Updates
Lead Judging Commences
inallhonesty 3 months ago
Submission Judgement Published Assigned finding tags:
RToken::rescueToken() can never be called
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.