Submission Details
Severity:
`updateFeeType` can't update the `Buy/Sell Swap Tax ` and `NFT Royalty Fees` properly
Summary
The is due to the following condition in the updateFeeType function:
if (
newFee.veRAACShare +
newFee.burnShare +
newFee.repairShare +
newFee.treasuryShare !=
BASIS_POINTS
) {
revert InvalidDistributionParams();
}
Vulnerability Details
The above block of code shows how if a user try to change the fee type percentages, he should inevitably go to 100%. This means that the last two fee types can't be properly updated with low percentages like 1 and 2 (as they are right now)
Impact
The fee manager can't change those 2 unless they hi 100%
Tools Used
Manual review
Recommendations
Remove this condition
Updates
Lead Judging Commences
inallhonesty about 1 month ago
Submission Judgement Published Assigned finding tags:
Fee shares for fee type 6 and 7 inside FeeCollector do not total up to the expected 10000 basis points, this leads to update problems, moreover they are 10x the specifications
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.