Core Contracts

Finding

As per the docs/natspec the burn() should return :

However that's not the case, the following is returned :
return (amount, totalSupply(), amount);

So the second value - totalSupply() is there, and even the third value - amount of underlying asset is correct. But the first value expected the amount of scaled tokens burned isn't correct. It should be amountScaled which is already made in the function however it isn't used.

Impact

If the return value is used somewhere, it could lead to parsing wrong values. However that's not the case till now, so Low severity.

Tools Used

Manual Review

Recommendations

Change the return statement of burn function to :