Submission Details
Severity:
Precision loss in `GuageController::_distributeToGauges` function
Summary
This is due to the following line of code in the function:
uint256 gaugeShare = (amount * gaugeWeights[i]) /
totalTypeWeight;
Vulnerability Details
At the end of the function the sum of all of the gaugeShare variables may be smaller than the amount input because of precision loss. Because of this some dust amount will be left undistributed
Impact
Because of this some dust amount may left undistributed
Tools Used
Manual Review
Recommendations
track the total sum of shares and compare them to the amount input. if the they are less, notify the rewards to the last gauge or to the biggest one
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
GaugeController's _distributeToGauges function leaves revenue undistributed due to integer division truncation when calculating gauge shares
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
GaugeController's _distributeToGauges function leaves revenue undistributed due to integer division truncation when calculating gauge shares
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.