Submission Details
Severity:
Missing 'whenNotPaused' modifier in 'finalizeLiquidation' function
Summary
Missing 'whenNotPaused' modifier in 'finalizeLiquidation' function.
Vulnerability Details
function finalizeLiquidation(address userAddress) external nonReentrant onlyStabilityPool {
Other functions have whenNotPaused modifiers, which is a safe approach, but finalizeLiquidation is missing. Even if it is called by onlyStabilityPool, it should not be callable when paused.
Impact
Liquidation can still be performed when the contract is suspended, potentially bypassing the contract's protections.
Tools Used
Manual review
Recommendations
The whenNotPaused modifier should always be added to ensure that critical operations cannot be performed in the paused state to ensure the safety of the system.
function finalizeLiquidation(address userAddress) external nonReentrant onlyStabilityPool whenNotPaused {
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.