Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Incorrect Time Comparison in whenActive Modifier

bshyuunn

01. Relevant GitHub Links

02. Summary

An issue occurs in the whenActive modifier of the Auction contract. The check uses a strict > comparison against startTime, which causes transactions to revert if block.timestamp matches state.startTime exactly.

03. Vulnerability Details

requires block.timestamp to be strictly greater than state.startTime. If the current block time is exactly state.startTime, the condition fails, preventing users from interacting with the auction at the intended start time.

modifier whenActive() {
require(block.timestamp > state.startTime, "Auction not started");
require(block.timestamp < state.endTime, "Auction ended");
_;
}

04. Impact

  • Auction participants cannot place bids at the exact moment the auction is supposed to begin.

  • This may lead to confusion and potential missed bids, reducing the usability and clarity of the auction process.

05. Tools Used

Manual Code Review and Foundry

06. Recommended Mitigation

modifier whenActive() {
- require(block.timestamp > state.startTime, "Auction not started");
+ require(block.timestamp >= state.startTime, "Auction not started");
require(block.timestamp < state.endTime, "Auction ended");
_;
}
Updates

Lead Judging Commences

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.