Submission Details
Severity:
Inconsistent State Updates
Summary
The _update function is called in some functions (e.g., deposit, withdraw, liquidateBorrower) but not in others (e.g., addManager, removeManager, updateAllocation). This could lead to inconsistent state updates.
Vulnerability Details
function addManager(address manager, uint256 allocation) external onlyOwner validAmount(allocation) {
if (managers[manager]) revert ManagerAlreadyExists();
managers[manager] = true;
managerAllocation[manager] = allocation;
totalAllocation += allocation;
managerList.push(manager);
emit ManagerAdded(manager, allocation);
}
/**
* @notice Removes an existing manager.
* @param manager Address of the manager to remove.
*/
function removeManager(address manager) external onlyOwner {
if (!managers[manager]) revert ManagerNotFound();
totalAllocation -= managerAllocation[manager];
delete managerAllocation[manager];
managers[manager] = false;
_removeManagerFromList(manager);
emit ManagerRemoved(manager);
}
Impact
inconsistent state updates.
Tools Used
Recommendations
Ensure that _update is called in all functions that modify state or interact with external contracts.
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.