Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

Loss of Previous Voting Power Upon lock function in VotingPowerLib.sol

shipkata494

Summary

userLock.amount + amount could be larger then maxLock amount

Vulnerability Details

User locks 1000 tokens for 2 years, gaining X voting power, later locks an additional 500 tokens through lock function and it overrides his locks and X voting power is lost instead of being added to the new calculation.

Impact

Users who extend or add to their locks may lose previously accumulated voting power.

Tools Used

Manual code review

Recommendation

function calculateAndUpdatePower(
VotingPowerState storage state,
address user,
uint256 amount,
uint256 unlockTime,
bool isFromLock // Нов параметър за разграничаване на първоначално заключване и увеличение
) internal returns (int128 bias, int128 slope) {
if (amount == 0 || unlockTime <= block.timestamp) revert InvalidPowerParameters();

function calculateAndUpdatePower(
VotingPowerState storage state,
address user,
uint256 amount,
uint256 unlockTime,
bool isFromLock //add additional parameter => if we call from lock is true otherwise is false
) internal returns (int128 bias, int128 slope) {
if (amount == 0 || unlockTime <= block.timestamp) revert InvalidPowerParameters();
uint256 MAX_LOCK_DURATION = 1460 days;
​
uint256 duration = unlockTime - block.timestamp;
uint256 initialPower = (amount * duration) / MAX_LOCK_DURATION;
​
bias = int128(int256(initialPower));
slope = int128(int256(initialPower / duration));
​
uint256 oldPower = getCurrentPower(state, user, block.timestamp);
​
if (isFromLock && oldPower != 0) {
revert UserHasAlreadyLocked();
}
​
state.points[user] = RAACVoting.Point({
bias: bias,
slope: slope,
timestamp: block.timestamp
});
​
_updateSlopeChanges(state, unlockTime, 0, slope);
​
emit VotingPowerUpdated(user, oldPower, uint256(uint128(bias)));
return (bias, slope);
}
​

}

Updates

Lead Judging Commences

inallhonesty Lead Judge 4 months ago
Submission Judgement Published
Validated
Assigned finding tags:

veRAACToken::lock called multiple times, by the same user, leads to loss of funds

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.