Submission Details
Severity:
`TimeWeightedAverage::self.totalDuration` is incorrectly initialized, leading to potential incorrect calculations.
Summary
TimeWeightedAverage::self.totalDuration does not require initialization as it is a cumulative value derived through accumulation. The current implementation erroneously initializes it to duration, resulting in an incorrect final value for TimeWeightedAverage::self.totalDuration.
Vulnerability Details
function createPeriod(
Period storage self,
uint256 startTime,
uint256 duration,
uint256 initialValue,
uint256 weight
) internal {
if (self.startTime != 0 && startTime < self.startTime + self.totalDuration) {
revert PeriodNotElapsed();
}
if (duration == 0) revert ZeroDuration();
if (weight == 0) revert ZeroWeight();
self.startTime = startTime;
self.endTime = startTime + duration;
self.lastUpdateTime = startTime;
self.value = initialValue;
self.weightedSum = 0;
self.totalDuration = duration; <==@found
self.weight = weight;
emit PeriodCreated(startTime, duration, initialValue);
}
Impact
Potential incorrect calculations.
Tools Used
Manual Review
Recommendations
Remove the initialization of
self.totalDuration.
Updates
Lead Judging Commences
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
TimeWeightedAverage::createPeriod incorrectly initializes totalDuration to period duration instead of zero, causing double-counting and inflated duration accumulation
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
TimeWeightedAverage::createPeriod incorrectly initializes totalDuration to period duration instead of zero, causing double-counting and inflated duration accumulation
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.