Submission Details
Severity:
getBoostMultiplier always return MAX_BOOST
Summary
getBoostMultiplier return MAX_BOOST instead of user current boost multiplier.
Vulnerability Details
function getBoostMultiplier(
address user,
address pool
) external view override returns (uint256) {
if (!supportedPools[pool]) revert PoolNotSupported();
UserBoost storage userBoost = userBoosts[user][pool];
if (userBoost.amount == 0) return MIN_BOOST;
// Calculate actual boost multiplier in basis points
uint256 baseAmount = userBoost.amount * 10000 / MAX_BOOST;
return userBoost.amount * 10000 / baseAmount;
}
Impact
getBoostMultiplier return MAX_BOOST instead of current boost. so if later use this function it could be an serious issue since user having MAX_BOOST.
Tools Used
Manual Review
Recommendations
Correct the calculation of getBoostMultiplier to return correct current user boost multiplier.
Updates
Lead Judging Commences
inallhonesty 4 months ago
Submission Judgement Published Assigned finding tags:
BoostController::getBoostMultiplier always returns MAX_BOOST for any non-zero boost due to mathematical calculation error, defeating the incentive mechanism
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.