Core Contracts

Description

In BaseGauge::constructor, the period calculation contains a redundant multiplication after division that can lead to precision loss. The current implementation first divides the timestamp by period duration and then multiplies by the same value, which can truncate the result unnecessarily.

Proof of Concept

Let's demonstrate with an example:

1. Assume currentTime = 1000 and _periodDuration = 7 days = 604800

2. 1000 / 604800 = 0 (integer division truncates)

3. 0 * 604800 = 0

4. 0 + 604800 = 604800

The issue is that the division and multiplication by _periodDuration is unnecessary and can lead to precision loss in edge cases where the timestamp is very large.

Recommendations

Remove Redundant Calculation