Core Contracts

Summary

Blocks per day is hardcoded to only work on ETH

Vulnerability Details

Block per day will only work on ETH as it's the only chain that has 12 second blocks:

https://github.com/Cyfrin/2025-02-raac/blob/main/contracts/core/minters/RAACMinter/RAACMinter.sol#L28

Impact

All others like ARB, BASE, POLY, OP, AVAX will no work properly. This is because it will configure the emissions wrong and would distribute too much, as emissions are per block and when one f the above chains has a block time of 2 seconds, the calculated emissions would be 6x as big.

Tools Used

Recommendations

Consider having it as an argument in the struct instead of a hard-coded value.