Submission Details
Severity:
`_mintRAACRewards` is called 2 times when depositing RTokens in the stability pool through `deposit` function, but only one call is needed.
Summary
deposit function in the Stability pool is defined as follows:
function deposit(uint256 amount) external nonReentrant whenNotPaused validAmount(amount) {
_update();
rToken.safeTransferFrom(msg.sender, address(this), amount);
uint256 deCRVUSDAmount = calculateDeCRVUSDAmount(amount);
deToken.mint(msg.sender, deCRVUSDAmount);
userDeposits[msg.sender] += amount;
_mintRAACRewards();
emit Deposit(msg.sender, amount, deCRVUSDAmount);
}
First it calls _update()which will call _mintRAACRewards in order to mint pending RAAC rewards for depositors.
But deposit function calls _mintRAACRewards again, which is superfluous and can be removed.
Impact
The impact of this issue is low.
Tools Used
Manual review.
Recommendations
Remove the second call to _mintRAACRewards which is not necessary.
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.