Core Contracts

Summary

The FeeCollector contract's updateFeeType function incorrectly requires all fee shares to total 10,000 basis points, preventing updates to fee types initialized with 2,000 basis points.

Vulnerability Details

Fee types 6 and 7 are initialized with total shares of 2,000 basis points, while all other fee types use 10,000 (the comments are incorrect because 1,000 basis points represent 10%):

However, updateFeeType incorrectly validates that shares must total 10,000 basis points:

Impact

Medium: Fee manager cannot update fee types 6 and 7 due to validation mismatch and is forced to use 10,000 basis points when lower basis points are needed.

Recommendations

Consider modifying or removing the validation logic, or initialize every fee type with 10,000 basis points to maintain initial state through updates.