Submission Details
Severity:
BaseGauge::setEmission can't be called because `GaugeController`doesn't implement functionality, blocking the protocol from update emissions
Summary
BaseGauge::setEmission function is created to allow reward emission resizing for a given period and can only be called by the GaugeController.
Vulnerability Details
GaugeControllerdoesn't implement any functionality to call a contract that inherits the BaseGaugeand triggers the setEmissionfunction.
- function setEmission(uint256 emission) external onlyController { <@
if (emission > periodState.emission) revert RewardCapExceeded();
periodState.emission = emission;
emit EmissionUpdated(emission);
}
Impact
The functionality will be blocked from usage and nobody will be able to call it.
Tools Used
Code review
Recommendations
Implement the needed functionality on GaugeControlleror refactor the BaseGauge::setEmissionfunction to allow other actors to call it.
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
`setWeeklyEmission`, `setBoostParameters`, `setEmission` and `setInitialWeight` cannot be called due to controller access control - not implemented in controller
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
`setWeeklyEmission`, `setBoostParameters`, `setEmission` and `setInitialWeight` cannot be called due to controller access control - not implemented in controller
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.