Submission Details
Severity:
Incorrect revert name in `Governance::_executeProposal`
Summary
The function checks whether an operation is ready to be executed by calling _timelock.isOperationReady(id), but if the operation is not ready, it reverts with an error message indicating that the proposal is not queued. This naming is misleading because the check is not verifying if the proposal is queued but rather if the operation is ready for execution.
if (!_timelock.isOperationReady(id)) {
revert ProposalNotQueued(proposalId, id); // <- FOUND
}
Recommendations
Update the error message from ProposalNotQueued to a more appropriate name (e.g., ProposalNotReady) that accurately reflects the check being performed.
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.