Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: high
Valid

Gauge rewards are calculated incorrectly

OpaBatyo

Summary

BaseGauge.earned function calculates earned rewards incorrectly due to getUserWeight returning the weight of the gauge instead of the user

Details

earned is supposed to calculate the rewards due to be paid to each user by multiplying the weight of their stake by the rewardPerToken variable. However, instead of fetching the amount of the user's stake, the function calls getUserWeight(user) which returns the weight of the gauge.

function getUserWeight(address account) public view virtual returns (uint256) {
uint256 baseWeight = _getBaseWeight(account); <@
return _applyBoost(account, baseWeight);
}
​
function _getBaseWeight(address account) internal view virtual returns (uint256) {
return IGaugeController(controller).getGaugeWeight(address(this)); <@
}

As we can see from the snippet above, _getBaseWeight is passed an account input which is actually unused. All users will be assigned incorrect rewards, disregarding their staked amount. Furthermore, rewards can be stolen by anyone, even if they are not a current staker by just invoking getRewards since they will too get assigned the gauge's weight as token balance.

Impact

Theft of funds, incorrect reward distribution, broken core functionality

Mitigation

Fetch the stake of the user instead of the gauge's weight

Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

BaseGauge::earned calculates rewards using getUserWeight instead of staked balances, potentially allowing users to claim rewards by gaining weight without proper reward checkpoint updates

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

BaseGauge::earned calculates rewards using getUserWeight instead of staked balances, potentially allowing users to claim rewards by gaining weight without proper reward checkpoint updates

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!