Submission Details
Severity:
Everyone will receive max boost due to `minBoost` not being in basis points
Details
Initial boost parameters in BaseGauge are as follows
// Initialize boost parameters
boostState.maxBoost = 25000; // 2.5x
boostState.minBoost = 1e18;
boostState.boostWindow = 7 days;
Min boost is denominated in 1e18 instead of basis points which will cause the snippet below to always return inflated amounts.
// Ensure boost is within bounds
if (boost < params.minBoost) { // @note this is always true
return params.minBoost;
}
if (boost > params.maxBoost) {
return params.maxBoost;
}
return boost;
Another affected place is _calculateBoost which will also return max amounts always
(uint256 boostBasisPoints, uint256 boostedAmount) = BoostCalculator.calculateTimeWeightedBoost(
params,
userBalance,
totalSupply,
amount
);
if (boostedAmount < amount) {
return amount;
}
uint256 maxBoostAmount = amount * MAX_BOOST / 10000;
if (boostedAmount > maxBoostAmount) { // @audit boostedAmount will always be absurdly high
return maxBoostAmount;
}
return boostedAmount;
boostedAmount will always be higher than maxBoostAmount due to being in 1e18, hence why everyone will receive max boost.
Impact
Unfair reward distribution, logic error
Mitigation
Use basis points for all boosts
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
boostState.minBoost is set to 1e18
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.