Submission Details
Severity:
FeeCollector fee types are initialized with incorrect shares
Summary
FeeCollector's swap taxes and NFT royalties fee types are initialized with incorrect shares. This will lead to incorrect fee distribution.
Vulnerability Details
In FeeCollector.__initializeFeeTypes, we have the following:
// Buy/Sell Swap Tax (2% total)
feeTypes[6] = FeeType({
veRAACShare: 500, // 0.5%
burnShare: 500, // 0.5%
repairShare: 1000, // 1.0%
treasuryShare: 0
});
// NFT Royalty Fees (2% total)
feeTypes[7] = FeeType({
veRAACShare: 500, // 0.5%
burnShare: 0,
repairShare: 1000, // 1.0%
treasuryShare: 500 // 0.5%
});
So the total share of swap tax rate and NFT royalties fee types are 2% respectively.
However, in order to correctly distribute fees, the total share should be 100%
This is enforced in FeeCollector.updateFeeType:
// Validate fee shares total to 100%
if (newFee.veRAACShare + newFee.burnShare + newFee.repairShare + newFee.treasuryShare != BASIS_POINTS) {
revert InvalidDistributionParams();
}
Impact
Colllected fees for swap tax rate and NFT royalties won't be distributed and stuck at FeeCollector
Recommendation
Total shares for these fee types should be 100% as well.
Updates
Lead Judging Commences
inallhonesty 7 months ago
Submission Judgement Published Assigned finding tags:
Fee shares for fee type 6 and 7 inside FeeCollector do not total up to the expected 10000 basis points, this leads to update problems, moreover they are 10x the specifications
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420
USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.